Thanks to visit codestin.com
Credit goes to github.com

Add tutorial about autoscaling #18840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jklymak merged 10 commits into matplotlib:master from deep-jkl:tutorial-autoscaling-basic

Dec 3, 2020

Contributor

deep-jkl commented Oct 29, 2020

PR Summary

I hope I have covered basic usage of autoscaling. Maybe there is a need to go more into details, but I suggest to do it in another tutorial, along with suggestions from #18401

Closes #17417

PR Checklist

[N/A] Has pytest style unit tests (and pytest passes).
Is Flake 8 compliant (run flake8 on changed files to check).
[N/A] New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs should build without error).
Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
[N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
[N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic requested review from brunobeltran and story645

October 29, 2020 21:38

QuLogic added the Documentation label

Contributor Author

deep-jkl commented Oct 30, 2020

Hi @QuLogic, is it possible to add hacktoberfest-accepted label, so that this PR counts towards the event?

deep-jkl force-pushed the tutorial-autoscaling-basic branch 2 times, most recently from 7539d20 to 138fd55 Compare

October 31, 2020 15:56

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

Member

jklymak left a comment

Nice job. I think this is useful, and I learned some things (even if I will never use them because I am pretty comfortable setting axes manually). Suggest more concision...

deep-jkl force-pushed the tutorial-autoscaling-basic branch from cbe7043 to e798987 Compare

November 16, 2020 20:26

QuLogic reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

jklymak reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

deep-jkl commented

View reviewed changes

Contributor Author

deep-jkl left a comment

Thank you for review, I hope this type of "change suggestions" is easier to process, just give me thumps up/down and I will add selected changes to the PR, squash it reasonably and prepare for another round of revisions (if needed).

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py

+              ###############################################################################
+              # Margins
+              # -------
+              # The default margin around the data limits is 5%:

Contributor Author

deep-jkl Nov 19, 2020

Suggested change

      
            # The default margin around the data limits is 5%:
          
            # The margin setting can be read out, its default value is 5%:

deep-jkl force-pushed the tutorial-autoscaling-basic branch from 50c7f6d to d01a2a9 Compare

November 22, 2020 09:41

timhoffm reviewed

View reviewed changes

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Outdated Show resolved Hide resolved

tutorials/intermediate/autoscale.py Show resolved Hide resolved

deep-jkl force-pushed the tutorial-autoscaling-basic branch from 4951d9b to d662a23 Compare

November 23, 2020 18:43

Jakub Klus and others added 6 commits

November 23, 2020 20:13


          Add tutorial about autoscaling

f5d2d29


          Condensed arguments formatting

1a17bc1


          Language corrections.

a8a2ebf


          Apply suggestions from code review

12412a1

Many thanks to @jklymak. I accept the suggestions as they are,
but I sense that there will be need for some code fixups.

Co-authored-by: Jody Klymak <[email protected]>


          Fix code after applying suggestions.

5ef253b


          Apply all suggestions from code review

a2961c0

Will be revised.

Co-authored-by: Jody Klymak <[email protected]>

Jakub Klus and others added 4 commits

November 23, 2020 20:13


          Fix flake8 formatting.

07bdd37


          Apply suggestions from code review

bc562ba

Co-authored-by: Tim Hoffmann <[email protected]>


          Remove fig.show()

d74ddb2


          Don't use "unchanged" use "default"

1308b8d

deep-jkl force-pushed the tutorial-autoscaling-basic branch from d662a23 to 1308b8d Compare

November 23, 2020 19:13

Contributor Author

deep-jkl commented Dec 3, 2020

bump

jklymak approved these changes

View reviewed changes

Member

jklymak left a comment

I'm going to go ahead and merge as an improvement. If anyone has further refinements, we can open a new PR.

Thanks a lot @deep-jkl !

jklymak added this to the v3.4.0 milestone

jklymak merged commit d1dad03 into matplotlib:master

Member

tacaswell commented Dec 9, 2020

Awesome, thank you @deep-jkl

deep-jkl deleted the tutorial-autoscaling-basic branch

April 13, 2022 18:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic left review comments

timhoffm timhoffm left review comments

jklymak jklymak approved these changes

brunobeltran Awaiting requested review from brunobeltran

story645 Awaiting requested review from story645

Labels