Improve hat graph example #18857
Merged
Improve hat graph example #18857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Nov 13, 2020
| @@ -10,42 +10,65 @@ | |||
| import matplotlib | |||
| import numpy as np | |||
| import matplotlib.pyplot as plt | |||
|
|
|||
There was a problem hiding this comment.
Can you fix the comment above while we are here? Refer ... to: "For discussion of hat graphs, see https://doi.org/10.1186/s41235-019-0182-3"
There was a problem hiding this comment.
Please feel free to self merge either way
There was a problem hiding this comment.
I've inlined the link into the first sentence by linking "hat graph" there.
QuLogic
reviewed
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Extract a
hat_graph()function, that can be readily copy/pasted by end-users.It would also be good to have some other data semantics. Hat graphs are designed to compare datasets with respect to a reference dataset. For players A/B, it seems a bit arbitrary that Player A is considered the reference player. Unfortunately, I currently cannot think of a good domain/data semantics. Suggestions welcome.