Resolve mathtext.fontset at FontProperties creation time. #18862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of delaying it until rendering time. This makes it consistent with the behavior of `rcParams["font.family"]`. (While lazy resolution may be useful too, it seems better to be consistent with family, whose behavior is constrained by backcompat, whereas mathtext_fontfamily has not been released yet.)
timhoffm
approved these changes
Nov 1, 2020
QuLogic
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of delaying it until rendering time. This makes it
consistent with the behavior of
rcParams["font.family"]. (While lazyresolution may be useful too, it seems better to be consistent with
family, whose behavior is constrained by backcompat, whereas
mathtext_fontfamily has not been released yet.)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).