-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Implementing ticklabels keyword in plt.colorbar() #18884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6936d2e
Implementing ticklabels keyword in plt.colorbar()
danuo 553e26a
Adding testing routing for ticklabels in plt.colorbar()
danuo 2d65c33
Adding keyword documentation of ticklabels in plt.colorbar()
danuo 60e2b34
Make colorbar._ticklabels a private variable
danuo 245936a
implement clear warnings for wrong ticks or ticklabels
danuo 0ab998f
fix indent for flake8
danuo f09711a
fix line length
danuo b00d5de
fix failing tests
danuo 58ebc94
implement more test cases
danuo 7e6de18
whitespace fix
danuo 6d58867
Fix regex expression with proper escape characters
danuo f993a3e
line length
danuo 239f5ac
fix table margin in docstring
danuo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to check these warnings and the next one if you have time for that....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, w/o reading the discussion, do we need all these warning checks? I don't think we usually check for mismatched type, for instance...