Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes MIME type for svg frame_format in HTMLWriter. #18892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

Fixes MIME type for svg frame_format in HTMLWriter. #18892

merged 1 commit into from
Nov 12, 2020

Conversation

ischurov
Copy link
Contributor

@ischurov ischurov commented Nov 4, 2020 •
edited
Loading

Closes #18891

PR Summary

Fixes MIME type for svg frame_format in HTMLWriter from image/svg to image/svg+xml.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic
QuLogic approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works on Firefox.

@timhoffm timhoffm added this to the v3.4.0 milestone Nov 12, 2020
@timhoffm timhoffm merged commit 5184577 into matplotlib:master Nov 12, 2020
@timhoffm
Copy link
Member

Thanks @ischurov and congratulations on your first contribution to Matplotlib. We'd be happy to see you back some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
backend: svg topic: animation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

SVG animation doesn't work in HTMLWriter due to wrong type
3 participants
@ischurov @timhoffm @QuLogic