Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove Artist.eventson and Container.eventson #18910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Nov 6, 2020

PR Summary

They are unused.

Closes #4877.

@timhoffm timhoffm added this to the v3.4.0 milestone Nov 6, 2020
@QuLogic
Copy link
Member

QuLogic commented Nov 7, 2020

No deprecation?

@timhoffm
Copy link
Member Author

timhoffm commented Nov 7, 2020

This has only ever existed as an attribute set in __init__. Does not appear in the documentation. Did not have any functionality for years (possibly ever).

Given that, it's extremely unlikely anybody is using it, and I dare removing without deprecation fuss.

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messed up rebase. anyone can dismiss once fixed.

@tacaswell tacaswell merged commit dbae370 into matplotlib:master Nov 17, 2020
@timhoffm timhoffm deleted the remove-eventson branch November 17, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort out if Artist.eventson is used anywhere and what it's fate should be
4 participants