Factor out common functionality in HostAxes.twin{,x,y}. #18913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Nov 8, 2020
|
|
||
| ax2.axis["top", "right"].set_visible(True) | ||
| ax2.axis["left", "bottom"].set_visible(False) | ||
| def _add_twin_common(self, axes_class, **kwargs): |
There was a problem hiding this comment.
I'd call this
Suggested change
| def _add_twin_common(self, axes_class, **kwargs): | |
| def _add_twin_axes(self, axes_class, **kwargs): |
- It actually does all the work of adding the twin axes. Whether it's a "common" method is secondary, and the docstring even indicates all the callers.
_add_twin_axesis a bit more explicit than_add_twin.
timhoffm
approved these changes
Nov 9, 2020
QuLogic
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).