Set clip path for PostScript texts. #18933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Nov 11, 2020
|
Power-cycled to re-run the tests after #18894 was merged. |
timhoffm
reviewed
Nov 22, 2020
The clip path/clip box were simply not set at all before. Also move `_convert_path`/`_get_clip_cmd` (previously `_get_clip_path`) above the block where all `draw_foo`s are defined, rather than being in the middle of them.
|
This looks fine to me (ahem, or at least the test looks reasonable and passes).... Does it need a change log entry though since postscrtip files will have changed? |
timhoffm
approved these changes
Jan 5, 2021
|
I would not write a change note in the sense that outputs change. This is either a bug fix or a new feature. If somebody wants to write a note then as a new feature. But IMHO that's optional. I'll leave this briefly open if somebody want to add a note. Anybody can merge after a day or two. |
|
I think I agree that it can just be merged. Just wanted to double check.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The clip path/clip box were simply not set at all before.
Also move
_convert_path/_get_clip_cmd(previously_get_clip_path)above the block where all
draw_foos are defined, rather than being inthe middle of them.
Closes #4321.
Goes on top of #18894.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).