-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: Fix latexpdf build #18948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DOC: Fix latexpdf build #18948
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8b6e341
Closes #15796: latex_elements defined twice in doc/conf.py
jfbu 2b212a0
LaTeX: resolve "Too deeply nested" error without enumitem package
jfbu 53d4170
LaTeX: use XITS and XITS Math for wide enough Unicode coverage
jfbu 8d9ebb5
Better looking general index in PDF documentation
jfbu e6b341d
LaTeX: backport sphinx-doc/sphinx/pull/6888 to fix double quote issue
jfbu 3947e83
Drop Extension = .otf lines from LaTeX font loading
jfbu 89b6314
Add missing dimension in genfrac LaTeX example.
QuLogic cd30a70
DOC: Fix some bugs in math symbol tables.
QuLogic 2bec173
DOC: Put bibliography/indices in their own Part.
QuLogic 2fd6983
DOC: Add explicit font filenames for some TeX systems.
QuLogic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dimension appears to be required by LaTeX, but not our parser. I couldn't find anything in the parser that could require it, (if we wanted to do that)?
cc @anntzer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed,
\genfrac
behaves differently between mathtext and TeX: TeX wants (quite reasonably) a unit whereas we have not implemented support for it. I don't actually know what's the unit we implicitly use?I guess adding support for units there is not "too" hard (mostly just figuring out the right multiplier); but in the meantime I guess you could just exclude that from the pdf build using
.. only::
or.. ifconfig::
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this is in
.. math::
; according to the build here, it works fine with the unit in regular HTML builds, too. It's just inconsistent with the Matplotlib version in the plain text source.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you should mostly just open an issue for supporting
{0pt}
on our side? (which seems like a reasonable request) Or did I miss something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as it seems I didn't miss anything, #19001.