Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document rasterized parameter in pcolormesh() explicitly #18956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 18, 2020

Conversation

philip-sparks
Copy link
Contributor

Update _axes.py to include mentions of rasterization within pcolormesh fixes #17708

PyData sprint contribution to enhance the documentation of rasterization within the pcolormesh function.

Update _axes.py to include mentions of rasterization within pcolormesh fixes matplotlib#17708
@timhoffm
Copy link
Member

Please check the flake8 errors and fix them.

Copy link
Contributor Author

@philip-sparks philip-sparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding flake8 changes

Copy link
Contributor Author

@philip-sparks philip-sparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing according to flake8 standards.

@philip-sparks
Copy link
Contributor Author

All checks have passed @timhoffm

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but don't know that this deserves a hint at the beginning, though linking the rasterization demo is nice.

Copy link
Contributor Author

@philip-sparks philip-sparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change for flake8 standards.

@QuLogic QuLogic changed the title Update _axes.py for #17708 Mention rasterized option in pcolormesh Nov 18, 2020
@QuLogic
Copy link
Member

QuLogic commented Nov 18, 2020

Please give your PRs more descriptive titles in the future.

@timhoffm timhoffm changed the title Mention rasterized option in pcolormesh Document rasterized parameter in pcolormesh() explicitly Nov 18, 2020
@timhoffm timhoffm merged commit c486cd7 into matplotlib:master Nov 18, 2020
@timhoffm timhoffm added this to the v3.3.4 milestone Nov 18, 2020
@timhoffm
Copy link
Member

Thanks, and congratulations on your first contribution to Matplotlib. We hope to see you again.

@QuLogic QuLogic modified the milestones: v3.3.4, v3.4.0 Nov 19, 2020
@tacaswell
Copy link
Member

It was great to meet you at pydata @philip-sparks !

@philip-sparks
Copy link
Contributor Author

Thank you @tacaswell @timhoffm , my first open source contribution! And it will not be my last.

@philip-sparks philip-sparks deleted the patch-1 branch November 19, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention rasterized option in more methods
5 participants