Remove special-casing for PostScript dpi in pyplot.py. #18964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is slightly inelegant for pyplot to special-case the PS backend for fixed dpi, and anyways unnecessary because FigureCanvasPS._print_ps forces the dpi to 72 when saving the figure anyways. This is the same strategy as used by the other vector backends (pdf/svg).
QuLogic
approved these changes
Nov 17, 2020
timhoffm
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is slightly inelegant for pyplot to special-case the PS backend for
fixed dpi, and anyways unnecessary because FigureCanvasPS._print_ps
forces the dpi to 72 when saving the figure anyways. This is the same
strategy as used by the other vector backends (pdf/svg).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).