Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix clabel() for backends without canvas.get_renderer() #18968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix clabel() for backends without canvas.get_renderer() #18968

merged 1 commit into from
Nov 18, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 17, 2020

tight_layout.get_renderer() does the right dance to set up a
renderer for any canvas. Perhaps it also should be moved somewhere
more easily findable and it should be better disambiguated with
backend_bases._get_renderer(), but that can be left for another
time...

Accidentally broke this in #16171.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Fix clabel() for backends without canvas.get_renderer()
d156691 
`tight_layout.get_renderer()` does the right dance to set up a
renderer for any canvas.  Perhaps it also should be moved somewhere
more easily findable and it should be better disambiguated with
`backend_bases._get_renderer()`, but that can be left for another
time...
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Nov 17, 2020
@anntzer anntzer added this to the v3.4.0 milestone Nov 17, 2020
@timhoffm timhoffm merged commit 48031d8 into matplotlib:master Nov 18, 2020
@anntzer anntzer deleted the contourgetbackend branch November 18, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dopplershift @timhoffm