Simplify GridHelper invalidation. #19042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Dec 1, 2020
GridHelperBase.invalidate/valid and Axes.invalidate_grid_helper are never used externally and appear to be internal. But invalidation doesn't need to be stored in a separate flag (`_force_update`), one can simply reset `_old_limits` (which only serves this purpose) and unify that with `_old_values` (which does the same). The only `_update` method that was previously called to regenerate invalidated grid info was `GridHelperCurveLinear._update`, which, other than the redundant check of staleness (already done in `_update_lim`), just forwarded to `_update_grid`, so get rid of `_update` and just stick to `_update_grid`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GridHelperBase.invalidate/valid and Axes.invalidate_grid_helper are
never used externally and appear to be internal. But invalidation
doesn't need to be stored in a separate flag (
_force_update), one cansimply reset
_old_limits(which only serves this purpose) and unifythat with
_old_values(which does the same).The only
_updatemethod that was previously called to regenerateinvalidated grid info was
GridHelperCurveLinear._update, which, otherthan the redundant check of staleness (already done in
_update_lim),just forwarded to
_update_grid, so get rid of_updateand juststick to
_update_grid.PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).