Prepare inlining MovieWriter.cleanup() into MovieWriter.finish(). #19046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs only mention `finish()`; but the implementations of `finish()` simply forwards themselves to `cleanup()` (and do a bit more). One can instead just put all the relevant logic in `finish()` and not expose a separate (basically internal) API.
cd44f8e to
cdec6b9
Compare
dopplershift
approved these changes
Nov 30, 2020
QuLogic
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs only mention
finish(); but the implementations offinish()simply forwards themselves to
cleanup()(and do a bit more). One caninstead just put all the relevant logic in
finish()and not expose aseparate (basically internal) API.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).