Remove _draw_{ticks2,label2}; skip extents computation in _update_ticks. #19048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As far as I can see, AxisArtist._draw_{ticks2,labels2} have never been
used, and are exactly identical to `_draw_{ticks,labels}` with the
exception that the call to `_update_{ticks,labels}` has additionally
been inlined.
- We don't need to compute the window extents in `_update_ticks` and
forward it in `_draw_ticks`: it's never used at the call sites, and
`get_tightbbox` (which is the sole consumer of this info) calls again
`major_ticklabels.get_window_extent` (as well as
`minor_ticklabels.get_window_extent`) itself.
QuLogic
approved these changes
Dec 1, 2020
|
This came in via cf2821a where it looks like the method got re-implemented and the old version was saved as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used, and are exactly identical to
_draw_{ticks,labels}with theexception that the call to
_update_{ticks,labels}has additionallybeen inlined.
_update_ticksandforward it in
_draw_ticks: it's never used at the call sites, andget_tightbbox(which is the sole consumer of this info) calls againmajor_ticklabels.get_window_extent(as well asminor_ticklabels.get_window_extent) itself.PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).