Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better validate tick direction. #19050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 30, 2020

  • Validate rcParams["{x,y}tick.direction"].
  • Move common validation and application to base Tick.apply_tickdir
    class. Note that previously YTick.apply_tickdir failed to
    _check_in_list the tickdir value.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

- Validate rcParams["{x,y}tick.direction"].
- Move common validation and application to base Tick.apply_tickdir
  class.  Note that previously YTick.apply_tickdir failed to
  _check_in_list the tickdir value.
@QuLogic QuLogic merged commit a9ada5c into matplotlib:master Dec 1, 2020
@QuLogic QuLogic added this to the v3.4.0 milestone Dec 1, 2020
@anntzer anntzer deleted the validate-tickdir branch December 1, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants