Small improvements to aitoff projection. #19076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use np.sinc instead of rewriting it ourselves. (This way, if numpy ever switches sinc to C, we get the speedup too.) - Make InvertedAitoff return nan (which is clearly suggests "we can't compute this") instead of being a noop (which makes it return nonsensical data with no user warning). AFAICT this is only used to print mouseover coordinates. See e.g. `subplots_axes_and_figures/geo_demo.py` where the mouseover coordinates for aitoff were just completely wrong.
dopplershift
approved these changes
Dec 7, 2020
QuLogic
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ever switches sinc to C, we get the speedup too.)
compute this") instead of being a noop (which makes it return
nonsensical data with no user warning). AFAICT this is only used
to print mouseover coordinates. See e.g.
subplots_axes_and_figures/geo_demo.pywhere the mouseovercoordinates for aitoff were just completely wrong.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).