Backport PR #19108 on branch v3.3.x #19115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
previously approved these changes
Dec 14, 2020
|
Are you sure about that? The test is still failing. |
- HTMLWriter inherits from FileMovieWriter. - FileMovieWriter create a non-context manager TemporayDirectory on init. - The TemporayDirectory is cleaned up in the cleaup method of FileMovieWriter. - However this method (and its call chain through finish) try to either call a subprocess to merge a bunch of single-frame files into a movie (not relevant) or to clean up such a process (not relevant). - The least disruptive fix is to duplicate the file clean up code.
|
@QuLogic and I talked through this today. The issue is:
This code probably should on the main branch, we will handle that with a careful merge up. |
|
#18679 doesn't appear to have been backported, and I guess it basically fixed the bug that is now getting exposed by pytest? |
Further simplify pgf tmpdir cleanup. Backports matplotlib#18679 but drops the deprecation steps.
|
I tried to backport the non-deprecation related changes. I think I missed these failures locally because I have other pgf failures due to latex changing under us (I see this on Arch, assume we will see it in test containers eventually, but that is a problem for the future). |
tacaswell
approved these changes
Dec 18, 2020
|
Ah, sorry, I was looking at |
QuLogic
reviewed
Dec 19, 2020
QuLogic
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #19108 on branch v3.3.x
In contrast to the original PR, no changes in tests are needed because we did not have tests that would trigger the warning back in 3.3.x.