Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GOV/DOC: add section to docs on triaging and triage team #19124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

tacaswell
Copy link
Member

PR Summary

This adds documentation to add a "triage team" to our organization as discussed on today's call. The purpose of this is to:

  • provide a low barrier to formally recognize users as contributing to the maintenance of Matplotlib (by giving them power and responsibility)
  • empower more people to help where they are willing and able
  • to incentive more people to triage issues
  • (secondary) provide a ramp / pipeline to contributing PRs (and reviewing PRs!) for new contributors

This text is based on https://scikit-learn.org/dev/developers/bug_triaging.html and modified to better fit Matplotlib.

Task that need to be done immediately outside of a PR if we merge this:

  • create triage_team in the github ACL system (I think only me @dopplershift and @efiring can currently do that?) with triage rights on matplotlib/matplotlib

If this catches on we may want to:

  • add more formal method of requesting to join (ex a form), but for now while we figure out if this is even a good idea, lets keep it informal.
  • add "triage team captain" or similar to the named roles in the governance docs, but again lets see if this catches on / is a good idea before we do that.

On the call I suggested 1 triage would be the threshold to be invited, but ended up with 2-3 just so that we have a bit more context to evaluate. Being optomistic, I expect most of these requests / nominations to be fulfilled.

sklearn has a slightly higher bar for inviting people to the triage team (https://scikit-learn.org/dev/governance.html#triage-team) and more ceremony, but I would rather have this be broader and less formal.

We can deal with bad-faith actors if they come up and I expect a vast majority of the issues we will have will be miss-labeled or miss-milestoned issues which are almost trivially fixable.

@tacaswell tacaswell added Documentation governance needs approval from @steering-council labels Dec 16, 2020
@tacaswell tacaswell added this to the v3.4.0 milestone Dec 16, 2020
@jklymak
Copy link
Member

jklymak commented Dec 22, 2020

@dopplershift @timhoffm @efiring This is on the agenda for today, but if you guys are OK with adding a "triage" layer to the Membership then you can hit approve. Thanks!

Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo.
Looks good to me.

or privately) to recommend you to the triage team . If you worked
with someone on the issue triaged, they would be a good person to
ask.
3. Responsibly exercise you new power!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you -> your

@tacaswell
Copy link
Member Author

I will merge this when docs pass CI.

@tacaswell
Copy link
Member Author

Testing @matplotlib/triageteam notification.

Co-authored-by: Elliott Sales de Andrade <[email protected]>
Co-authored-by: hannah <[email protected]>
@tacaswell tacaswell merged commit 8808573 into matplotlib:master Dec 23, 2020
@tacaswell tacaswell deleted the doc_triage_team branch December 23, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation governance needs approval from @steering-council
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants