Ignore closepoly vertices in _update_patch_limits. #19159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Dec 21, 2020
| tol = 16*sys.float_info.epsilon | ||
| ax.add_patch(mpatches.Wedge((0, -1), 1.05, 60, 120, 0.1)) | ||
| bounds = ax.dataLim.bounds | ||
| bot = 1.9*math.sin(15*math.pi/180)**2 |
There was a problem hiding this comment.
Just use numpy for these rather than importing math? You may also want to look at np.testing.assert_allclose rather than writing your own tolerance.
|
Did you mean to close this? |
|
Likely made obsolete by #19088... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR removes CLOSEPOLY vertices from the list of vertices used to find the data limits in _update_patch_limits.
Fixes #19078.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).