Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix 3D surface example bug for non-square grid #19172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2020

Conversation

ufmayer
Copy link
Contributor

@ufmayer ufmayer commented Dec 24, 2020

PR Summary

Fix 3D surface example bug for non-square grid (issue 19171) by changing the order of the indexers.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@ufmayer
Copy link
Contributor Author

ufmayer commented Dec 24, 2020

Build failed with:

Run actions/first-interaction@v1
/usr/bin/docker run --name cc49568ec20827035848788545584cc4edde94_4d9775 --label cc4956 --workdir /github/workspace --rm -e INPUT_REPO-TOKEN -e INPUT_PR-MESSAGE -e INPUT_ISSUE-MESSAGE -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/matplotlib/matplotlib":"/github/workspace" cc4956:8ec20827035848788545584cc4edde94
[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead
[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead
Checking if its the users first contribution
Checking...
(message repeats > 100 times)
Checking...
Adding message: Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while please feel free to ping `@matplotlib/developers` or anyone who has commented on the PR.  Most of our reviewers are volunteers and sometimes things to fall through the cracks.
You can also join us [on gitter](https://gitter.im/matplotlib/matplotlib) for real-time discussion.
For details on testing, writing docs, and our review process please see [the developer guide](https://matplotlib.org/devdocs/devel/index.html)
We strive to be a welcoming and open project, please follow our [Code of Conduct](https://github.com/matplotlib/matplotlib/blob/master/CODE_OF_CONDUCT.md). to pull request 19172
Error: Resource not accessible by integration

This appears not to be related to this PR but a general system issue.

@ufmayer
Copy link
Contributor Author

ufmayer commented Dec 24, 2020

Other failures are inherited from upstream repo, specifically ubuntu-16.04 tests. Several tests show as canceled and one shows a failed threading test, not related to this PR:

Python 3.7 on ubuntu-16.04 (Minimum Versions)
Run xvfb-run -a python -mpytest -raR -n auto \
  xvfb-run -a python -mpytest -raR -n auto \
    --maxfail=50 --timeout=300 --durations=25 \
    --cov-report= --cov=lib --log-level=DEBUG
  shell: /bin/bash -e {0}
  env:
    NO_AT_BRIDGE: 1
    OPENBLAS_NUM_THREADS: 1
    PYTHONFAULTHANDLER: 1
    pythonLocation: /opt/hostedtoolcache/Python/3.7.9/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.7.9/x64/lib
============================= test session starts ==============================
platform linux -- Python 3.7.9, pytest-6.2.1, py-1.10.0, pluggy-0.13.1
rootdir: /home/runner/work/matplotlib/matplotlib, configfile: pytest.ini, testpaths: lib
plugins: forked-1.3.0, cov-2.10.1, timeout-1.4.2, xdist-2.2.0, rerunfailures-9.1.1
timeout: 300.0s
timeout method: signal
timeout func_only: False
...
FAILED lib/matplotlib/tests/test_backends_interactive.py::test_interactive_thread_safety[qt5cairo0]

@ufmayer
Copy link
Contributor Author

ufmayer commented Dec 25, 2020

Merged in the upstream master, the build failures have been resolved.

@jklymak jklymak added this to the v3.4.0 milestone Dec 25, 2020
@jklymak jklymak merged commit 28efb11 into matplotlib:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D surface example bug for non-square grid
2 participants