Fixed failing bbox_inches='tight' case when a contour collection is empty #1929
Conversation
|
LGTM 👍 for merge |
|
Maybe rebase for the 1.2.x branch, then looks good to me. |
You're right that the bug has existed for a good while, but it is only manifest with a recent change to master, so nobody is going to see this unless they are doing some pretty low-level interface stuff. Long and short: I'm not that keen to rebase as I don't think it will make much difference, and I haven't verified that the change makes sense before the change that made this a problem. Obviously, if you feel strongly about it, I'd be happy enough to rebase against Cheers, |
|
My vote is to merge this to master and then not worry about back-porting if you are unsure about this breaking something in v1.2.x. As the one who posted this to the IPython listserv, getting this fix into master sooner rather than later will greatly help my local codebase. Just my $0.02 |
Fixed failing bbox_inches='tight' case when a contour collection is empty
|
Thanks @mdboom |
|
FWIW: I did cherry-pick this to 1.2.x as well. |
😄 thanks for the heads up |
Identified on the ipython-dev mailinglist: http://python.6.x6.nabble.com/Maptlotlib-Contour-Issue-Bug-with-IPython-Notebook-td5014995.html