Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix some packaging issues #19306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 15, 2021

PR Summary

Fix the license check for the added Qhull license and avoid adding a huge node_modules directory to the sdist.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added the Build label Jan 15, 2021
@QuLogic QuLogic added this to the v3.4.0 milestone Jan 15, 2021
@timhoffm
Copy link
Member

For a web-noob, can you explain what node_modules contains and why we can exclude it? 🤔

@ianhi
Copy link
Contributor

ianhi commented Jan 17, 2021

@timhoffm:
image
I guess that meme is kind of: why you should exclude, though not why you can. That part is also a bit mysterious to me.

(I think it's basically where all of the javascript packages get stored so that you have something like virtual env for a given js project.) But then I'm also a web noob so if someone has a more substantive explanation please don't let mine stop yours

@jklymak
Copy link
Member

jklymak commented Jan 17, 2021

I think @timhoffm meant "why did we need it before, and why can we exclude it now?"

@timhoffm
Copy link
Member

Maybe we didn't even need it before, but only nobody bothered to exclude it.

Rephrased question: Everything in the sources serves some purpose. Most of these things should be packaged. But apparently node_modules are not relevant for distribution. I'd like to roughly understand what it is and why it is not needed for distribution.

A rough explanation in 1-2 sentences is enough.

@QuLogic
Copy link
Member Author

QuLogic commented Jan 18, 2021

The node_modules directory was never needed before, and was never included, because sdists were created from a clean checkout. It would be created if you were working on the JS side of things and installed the linters and ponyfills we specified in packages.json. Excluding it is a convenience for anyone in that position who wants to test sdists, because that directory is somehow almost just as large as the rest of Matplotlib (yes, including test images).

@jklymak jklymak merged commit 04d4a78 into matplotlib:master Jan 19, 2021
@QuLogic QuLogic deleted the fix-license-check branch January 19, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants