Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix building against system qhull #19329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2021
Merged

Fix building against system qhull #19329

merged 2 commits into from
Jan 21, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 21, 2021

PR Summary

It always tries to download it, even with the option set. It also links against qhull, but should use qhull_r now.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. Build labels Jan 21, 2021
@QuLogic QuLogic added this to the v3.4.0 milestone Jan 21, 2021
anntzer
anntzer reviewed Jan 21, 2021
View reviewed changes
@ianthomas23
Copy link
Member

Confirmed this works on ubuntu 20.04 using

  1. System qhull from ubuntu packages (qhull 2015.2)
  2. System qhull manually downloaded, compiled and installed (qhull 2020.2)
  3. Default of downloading from qhull website (2020.2)

In all 3 cases correctly links against re-entrant qhull (qhull_r).

@jklymak
Copy link
Member

jklymak commented Jan 21, 2021

Thanks @ianthomas23

@jklymak jklymak merged commit 2dacb1c into matplotlib:master Jan 21, 2021
@QuLogic QuLogic deleted the fix-system-qhull branch January 21, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthomas23 ianthomas23 ianthomas23 approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Build Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @ianthomas23 @jklymak @anntzer