Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move sphinx extension files into mpl-data. #19337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2021
Merged

Move sphinx extension files into mpl-data. #19337

merged 2 commits into from
Jan 28, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 22, 2021

PR Summary

And then ensure it is included in sdists and installed.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.4.0 milestone Jan 22, 2021
anntzer
anntzer reviewed Jan 27, 2021
View reviewed changes
@QuLogic QuLogic force-pushed the move-sphinxext-data branch from 243f2b7 to 160d922 Compare January 27, 2021 07:45
@QuLogic
Move sphinx extension files into mpl-data.
a0b93fe 
And then ensure it is included in sdists and installed.
@QuLogic
Simplify mpl-data inclusion in sdists.
5ac3627 
With matplotlib#19383, there's no need to list each `mpl-data` subdirectory
individually.
@QuLogic QuLogic force-pushed the move-sphinxext-data branch from 160d922 to 5ac3627 Compare January 28, 2021 06:19
@QuLogic QuLogic added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 28, 2021
@anntzer anntzer merged commit 9b3b111 into matplotlib:master Jan 28, 2021
@QuLogic QuLogic deleted the move-sphinxext-data branch January 28, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: sphinx extension
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @timhoffm