Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add pkgconfig to homebrew install instruction #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2013
Merged

add pkgconfig to homebrew install instruction #1936

merged 1 commit into from
Apr 24, 2013

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Apr 23, 2013

build will not find freetype headers without it.

Alternate fix would be to search for freetype in the homebrew location (/usr/local/Cellar/freetype/VERSION/), or add the right location to the include path (/usr/local/include/freetype2).

build will not find freetype headers without it.

Alternate fix would be to search for freetype in the homebrew location (`/usr/local/Cellar/freetype/VERSION/`), or add the right location to the include path (`/usr/local/include/freetype2`).
@mdboom
Copy link
Member

mdboom commented Apr 23, 2013

I'm wary of adding more hard-coded include paths to the system -- it can then be difficult for users to override that when they want to, say, use a locally built copy of freetype.

We could also display a more prominent message when pkg-config can't be found...

@minrk
Copy link
Contributor Author

minrk commented Apr 23, 2013

You use freetype-config to discover the freetype version, but you don't use it to generate the compile flags, so that's another option. Following the current README.osx will result in a successful "you have freetype 2.4.11", but the compilation will actually fail. freetype-config --libs and freetype-config --cflags should give the relevant info.

@pelson
Copy link
Member

pelson commented Apr 24, 2013

Alternate fix would be to search for freetype in the homebrew location

Do we need an alternative fix? It sounds to me like adding pgkconfig to the install list is a good idea...

👍

@mdboom
Copy link
Member

mdboom commented Apr 24, 2013

@minrk, @pelson: I agree that adding pkgconfig to the install list is a good idea in any event, though I also like the suggestion of trying to use freetype-config in addition to pkg-config (I hadn't thought of that, and I think that's a good suggestion). I'll work the latter up as a separate PR, and we can go ahead and merge this one.

pelson added a commit that referenced this pull request Apr 24, 2013
add pkgconfig to homebrew install instruction
@pelson pelson merged commit d431c2e into matplotlib:master Apr 24, 2013
@minrk minrk deleted the macpkgconfig branch April 26, 2013 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants