Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test for align_ylabel bug with constrained_layout #19373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2021
Merged

test for align_ylabel bug with constrained_layout #19373

merged 3 commits into from
Jan 31, 2021

Conversation

Hathaway2010
Copy link

PR Summary

Checks for bug in which align_ylabel drives y labels of some subplots off the edge of the plot when using constrained layout under the circumstances laid out here: #19152 . This is my first contribution to open-source, so any feedback is helpful! On the first checklist item, I'm not sure what "pytest style unit tests" are in particular, and I'm having trouble getting the test suite to run at all, though I managed the first time I cloned the repository and my added test performed as it should have.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A ] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [X ] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A ] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

github-actions[bot]
github-actions bot reviewed Jan 27, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@Hathaway2010 Hathaway2010 marked this pull request as ready for review January 27, 2021 18:58
jklymak
jklymak approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jklymak jklymak added topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: testing labels Jan 27, 2021
@jklymak jklymak added this to the v3.4.1 milestone Jan 27, 2021
QuLogic
QuLogic reviewed Jan 28, 2021
View reviewed changes
@Hathaway2010 Hathaway2010 force-pushed the test-for-issue-19152 branch 2 times, most recently from 87a475b to 4b0ea8e Compare January 28, 2021 18:35
@QuLogic
Copy link
Member

QuLogic commented Jan 29, 2021

Can you rebase on latest master? It should fix most CI. You might also want to give the first commit a more descriptive message.

@jklymak
Copy link
Member

jklymak commented Jan 31, 2021

No I don't think the issues are with this PR. Thanks a lot for your persistence and help!

@jklymak jklymak merged commit cd0c551 into matplotlib:master Jan 31, 2021
@QuLogic QuLogic modified the milestones: v3.4.1, v3.4.0 Feb 1, 2021
@jklymak jklymak mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: testing
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hathaway2010 @QuLogic @jklymak