Simplify axisartist line clipping. #19401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec937be to
39cb499
Compare
|
I wonder if we should change axisartist's review policy to one review to allow it to improve faster? I'm also not sure there is a cadre of folks who understand it well enough to help, and since it is not core, there is less risk to breakage. |
39cb499 to
02a6d0a
Compare
QuLogic
approved these changes
Apr 16, 2021
axisartist.clip_path is currently used to clip the paths for curvilinear grid lines and compute the angles at which the ticks are drawn. We don't actually need to clip the lines (because we can just set a clipbox on the gridline instead); actually we just need to find the crossings positions and angles, which is much simpler, and now encapsulated in the `_find_line_box_crossings` function. Therefore, deprecate the whole clip_path module. The baseline images change slightly, mostly because we don't clip the path ourselves anymore, but let the renderer do that; also because floating point slop changes for ticks exactly at the edges.
02a6d0a to
62ed6f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axisartist.clip_path is currently used to clip the paths for curvilinear
grid lines and compute the angles at which the ticks are drawn.
We don't actually need to clip the lines (because we can just set a
clipbox on the gridline instead); actually we just need to find the
crossings positions and angles, which is much simpler, and now
encapsulated in the
_find_line_box_crossingsfunction. Therefore,deprecate the whole clip_path module.
The baseline images change slightly, mostly because we don't clip the
path ourselves anymore, but let the renderer do that; also because
floating point slop changes for ticks exactly at the edges.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).