Support empty stairs. #19426
Merged
Support empty stairs. #19426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm struggling to think of a use case (I don't quite understand the discussion in #18934) for this, but also can't think of a good reason not to allow it through. Could you add a little bit to the current test to check that autoscaling works correctly, ie. that
|
I have some process whose output is a stepwise constant function (f(x) = y0 from x0 to x1, = y1 from x1 to x2, etc.), so it can naturally be plotted using stairs(). Depending on the conditions, sometimes the process generates zero steps (so there's an x0 and things immediately stop, without even generating a y0). To handle that case I need stairs to support empty y's.
Sure. |
QuLogic
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #18934 (although @timhoffm has argued against supporting this case).
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).