-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add overset/underset whatsnew entry #19497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`.mathtext`, the default TeX layout engine which is shipped along with | ||
Matplotlib now supports symbols like *overset* and *underset*. | ||
|
||
The structure which should be followed: "\overset{body}{annotation}" or | ||
"\underset{body}{annotation}", where *body* would be the text "above" or | ||
"below" the *annotation* - the baseline character. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`.mathtext`, the default TeX layout engine which is shipped along with | |
Matplotlib now supports symbols like *overset* and *underset*. | |
The structure which should be followed: "\overset{body}{annotation}" or | |
"\underset{body}{annotation}", where *body* would be the text "above" or | |
"below" the *annotation* - the baseline character. | |
`.mathtext` now supports *overset* and *underset*, called as | |
``\overset{body}{annotation}`` or ``\underset{body}{annotation}``, where | |
*annotation* is the text "above" or "below" the *body*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest more direct language. Also I think your transposed "body" and "annotation"
👍🏼
matplotlib/lib/matplotlib/_mathtext.py Lines 2875 to 2879 in 56d9e7c
|
I guess I didn't pay attention in my original review; certainly "body" should be the main thing and "annotation" the out-of-alignment extra thing. |
OK, that is super confusing. In Ooops, crosspost with above. |
I can clean the logic up in this PR |
--------------------------------------------------------------------------- | ||
|
||
`.mathtext` now supports *overset* and *underset*, called as | ||
``\overset{body}{annotation}`` or ``\underset{body}{annotation}``, where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but now this is wrong again, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I blindly copied the suggestion, let me fix that
PR Summary
This is a continuation of the previous PR #18916,
w.r.t. this comment: #18916 (comment)
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).