Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prefer projection="polar" over polar=True. #19502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 11, 2021

... per dev call.

The docstring of add_axes/add_subplot still needs to be changed, but
this should wait until after projection reuse behavior is finalized.

Also, cases of polar=True in the tests have been left as such, to keep
exercising that API.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

... per dev call.

The docstring of add_axes/add_subplot still needs to be changed, but
this should wait until after projection reuse behavior is finalized.

Also, cases of polar=True in the tests have been left as such, to keep
exercising that API.
@tacaswell tacaswell added this to the v3.4.0 milestone Feb 11, 2021
@QuLogic QuLogic merged commit c0c3b03 into matplotlib:master Feb 17, 2021
@anntzer anntzer deleted the pp branch February 17, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants