Fix tight_layout() on "canvasless" figures. #19503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23f1f95 to
e5b05b9
Compare
This patch avoids a deprecation warning ("unexpected argument 'dpi'")
on `Figure().tight_layout()`. To do so we stop passing `dpi` to
`print_foo`, which is actually fine because `print_figure` already sets
the figure dpi to whatever value we will want, so `print_foo` can just
read `self.figure.dpi`. (The pgf backend already handles that
correctly.)
QuLogic
approved these changes
Feb 12, 2021
jklymak
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch avoids a deprecation warning ("unexpected argument 'dpi'")
on
Figure().tight_layout(). To do so we stop passingdpitoprint_foo, which is actually fine becauseprint_figurealready setsthe figure dpi to whatever value we will want, so
print_foocan justread
self.figure.dpi.Closes #19486.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).