In scatter, fix single rgb edgecolors handling #19539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Feb 18, 2021
| @@ -4507,6 +4507,11 @@ def scatter(self, x, y, s=None, c=None, marker=None, cmap=None, norm=None, | |||
| x, y, s, c, colors, edgecolors, linewidths = \ | |||
| cbook._combine_masks( | |||
| x, y, s, c, colors, edgecolors, linewidths) | |||
| # Unmask edgecolors if it was actually a single RGB or RGBA. | |||
| if (x.size in (3, 4) | |||
There was a problem hiding this comment.
Do we need a similar block for colors as well?
There was a problem hiding this comment.
I believe that is already an (N,4) array out of _parse_scatter_color_args and should have broadcast correctly with the masks.
There was a problem hiding this comment.
No, because the case that was problematic for colors was the case where edgecolors was being
set from colors, above all this. So handling edgecolors here takes care of it.
tacaswell
approved these changes
Feb 19, 2021
QuLogic
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19066.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).