Correctly check inaxes for multicursor #19636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are very few widget tests, so if you want to write one, that'd be great. |
dstansby
requested changes
Mar 7, 2021
Hi @dstansby thanks for pinging me here. Work got busy, and it suddenty wasn't allllways below freezing so I've been making a concsious effort to be outside instead of on my computer and let this slip - sorry about that! Anyway I added a test which I think covers most what seems relevant for MultiCursor. |
timhoffm
approved these changes
Mar 13, 2021
Closed
|
Since this is a bugfix could it be re-milestoned to Apparently people are running into this, see #20231 |
|
@meeseeksdev backport to v3.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 14, 2021
jklymak
added a commit
that referenced
this pull request
May 14, 2021
…636-on-v3.4.x Backport PR #19636 on branch v3.4.x (Correctly check inaxes for multicursor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
multicursor now checks if
event.inaxesis one of the axes it will draw on.Fixes: #19635
Before
After:
PR Checklist
There aren't any multicursor tests - does this change need a test?
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).