Fix Bbox.frozen() not copying minposx/minposy #19641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Agriad <[email protected]> Co-authored-by: davek10 <[email protected]> Co-authored-by: tjr16 <[email protected]>
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
QuLogic
reviewed
Mar 4, 2021
This function copies minpos when frozen is called. This commit resolves matplotlib#19296. Co-authored-by: Agriad <[email protected]> Co-authored-by: davek10 <[email protected]> Co-authored-by: tjr16 <[email protected]>
anntzer
approved these changes
Mar 5, 2021
tacaswell
approved these changes
Mar 5, 2021
|
Thanks @m4reko! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The problem that this PR resolves is that
Bbox.frozen()does not copy the minpos values which is a problem when using log scaling. This should resolve #19296.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).