Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't turn check_for_pgf into public API. #19643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 5, 2021

It was accidentally(?) added to the public API in the yet-to-be-released
1173770.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

It was accidentally(?) added to the public API in the yet-to-be-released
1173770.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing labels Mar 5, 2021
@anntzer anntzer added this to the v3.4.0 milestone Mar 5, 2021
@QuLogic QuLogic requested a review from tacaswell March 5, 2021 06:23
@tacaswell tacaswell merged commit e912e8b into matplotlib:master Mar 5, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 5, 2021
QuLogic added a commit that referenced this pull request Mar 6, 2021
…643-on-v3.4.x

Backport PR #19643 on branch v3.4.x (Don't turn check_for_pgf into public API.)
@anntzer anntzer deleted the ucfp branch March 6, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants