Thanks to visit codestin.com
Credit goes to github.com

Skip to content

deprecate_privatize_attribute also works for privatizing methods. #19653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2021
Merged

deprecate_privatize_attribute also works for privatizing methods. #19653

merged 1 commit into from
Mar 9, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 6, 2021

... with no changes (there's now a test for that).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
deprecate_privatize_attribute also works for privatizing methods.
292935d 
... with no changes (there's now a test for that).
QuLogic
QuLogic approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is nice, but all the things you've updated for it are about to be deleted.

@QuLogic QuLogic added this to the v3.5.0 milestone Mar 9, 2021
@QuLogic QuLogic merged commit 969a12c into matplotlib:master Mar 9, 2021
@anntzer
Copy link
Contributor Author

anntzer commented Mar 9, 2021

The point was mostly to show that this can be used for future deprecations too.

@anntzer anntzer deleted the dpam branch March 16, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm