DOC: Increase size of headings #19695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying a single font name later, and using normal switches for bold/italic. This also means if the font didn't load, the fallbacks will get the right style.
Some time ago, we switch to Carlito, but this font seems to be a bit smaller than our body font. The default styling makes fourth-level headings (`h4`) the same size as text, but bold. With the smaller font, this incorrectly makes the fourth-level headings look smaller than the text. To match the body font, Carlito needs a base size of 16px (vs 14px), so re-scale all the headings using the CSS default em-size * 16px.
timhoffm
approved these changes
Mar 13, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 13, 2021
timhoffm
added a commit
that referenced
this pull request
Mar 14, 2021
…695-on-v3.4.x Backport PR #19695 on branch v3.4.x (DOC: Increase size of headings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Some time ago, we switch to Carlito, but this font seems to be a bit smaller than our body font.
The default styling makes fourth-level headings (
h4) the same size as text, but bold:With the smaller font, this incorrectly makes the fourth-level headings look smaller than the text:
To match the body font, Carlito needs a base size of 16px (vs 14px), so re-scale all the headings using the CSS default em-size * 16px:
Additionally, define the custom font under one name, instead of multiple. This means that styles use the normal CSS, and font fallbacks will get the right style.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).