Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix arrow_guide.py typo #19709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Conversation

smartlixx
Copy link
Contributor

PR Summary

Just some corrections to the typos and redundancy in arrow_guide.py.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Copy link
Contributor

anntzer commented Mar 15, 2021

anyone can merge postci.

@anntzer anntzer added this to the v3.4.0 milestone Mar 15, 2021
@smartlixx
Copy link
Contributor Author

There are 3 errors in CI. All are linking with units:

Unexpected failing examples:
/home/circleci/project/examples/units/ellipse_with_units.py failed leaving traceback:
Traceback (most recent call last):
  File "/home/circleci/project/examples/units/ellipse_with_units.py", line 33, in <module>
    x, y = np.dot(R, [x, y])
  File "<__array_function__ internals>", line 6, in dot
FutureWarning: The input object of type 'TaggedValue' is an array-like implementing one of the corresponding protocols (`__array__`, `__array_interface__` or `__array_struct__`); but not a sequence (or 0-D). In the future, this object will be coerced as if it was first converted using `np.array(obj)`. To retain the old behaviour, you have to either modify the type 'TaggedValue', or assign to an empty array created with `np.empty(correct_shape, dtype=object)`.

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are unrelated to the content of this PR.

@timhoffm timhoffm merged commit afbcb50 into matplotlib:master Mar 15, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 15, 2021
QuLogic added a commit that referenced this pull request Mar 15, 2021
…709-on-v3.4.x

Backport PR #19709 on branch v3.4.x (Fix arrow_guide.py typo)
@smartlixx smartlixx deleted the fix-arrow-guide-typo branch March 16, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants