Remove "Use show()" from how-to #19867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Apr 4, 2021
lib/matplotlib/pyplot.py
Outdated
|
|
||
| Notes | ||
| ----- | ||
| **Saving figures only to file** |
There was a problem hiding this comment.
Numpydoc does not support subsections. I use an all-bold paragraph as a workaround. This is already used in other docstrings. See e.g. plot().
timhoffm
commented
Apr 4, 2021
Comment on lines
-318
to
-323
| In non-interactive mode, *block* defaults to True. All figures | ||
| will display and show will not return until all windows are closed. | ||
| If there are no figures, return immediately. | ||
|
|
||
| In interactive mode *block* defaults to False. This will ensure | ||
| that all of the figures are shown and this function immediately returns. |
There was a problem hiding this comment.
Description of block defaults moved into parameter description.
tacaswell
approved these changes
Apr 6, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 6, 2021
QuLogic
added a commit
that referenced
this pull request
Apr 6, 2021
…867-on-v3.4.x Backport PR #19867 on branch v3.4.x (Remove "Use show()" from how-to )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move relevant content to show() docstring instead.
savefig()moved (and expanded).show()and does not need a detailed discussion here.