FIX: re-order unit conversion and mask array coercion #19876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be sensible to ask pandas to add a test for this too (with their converters)? |
jklymak
approved these changes
May 6, 2021
|
sorry, Elliott and I talked about how to test this yesterday and then I did not get to it yet. |
4b1b9d8 to
0618a81
Compare
0618a81 to
4f23d61
Compare
QuLogic
approved these changes
May 7, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 7, 2021
QuLogic
added a commit
that referenced
this pull request
May 7, 2021
…876-on-v3.4.x Backport PR #19876 on branch v3.4.x (FIX: re-order unit conversion and mask array coercion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix for #19871 but still needs tests.
I am hesitant to register the pandas converters because the test should still be useful to us even if pandas changes to returning arrays and because making sure we de-register the pandas handlers on failure is a bit fiddly.
This probably also fixes some latent bugs where the
safe_masked_invalidwas up-converting to an array too soon.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).