Fix textbox cursor color, set its linewidth. #19903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cursor used to be black but the default of vlines color now matches `rcParams["lines.color"]` (blue), so change that back to black. Setting the linewidth to 1 also looks a bit nicer (than the thicker default linewidth).
timhoffm
approved these changes
Apr 8, 2021
QuLogic
approved these changes
Apr 9, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 9, 2021
QuLogic
added a commit
that referenced
this pull request
Apr 9, 2021
…903-on-v3.4.x Backport PR #19903 on branch v3.4.x (Fix textbox cursor color, set its linewidth.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor used to be black but the default of vlines color now matches
rcParams["lines.color"](blue) (#16953), so change that back to black. Settingthe linewidth to 1 also looks a bit nicer (than the thicker default
linewidth).
before:
after:
(Technically changing the color is a bugfix and whereas the linewidth is a new "feature", but splitting this into two PRs seems overkill. Also there's no tests whatsoever for TextBox right now...)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).