Implement get_cursor_data for QuadMesh. #19908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Apr 8, 2021
| data_str = ', '.join('{:0.3g}'.format(item) for item in data | ||
| if isinstance(item, Number)) | ||
| return "[" + data_str + "]" | ||
| if np.ndim(data) == 0 and getattr(self, "colorbar", None): |
There was a problem hiding this comment.
Is there better criterion than having a colorbar?
You still have a value (~color) in the mesh even if that's not explained via a colorbar. It would be nice if this works for a simple plt.pcolormesh() call. Also if you plot on multiple Axes with "shared" colors and use only one colorbar as description, AFAIK only one of the Mappables will be associated with the colorbar.
There was a problem hiding this comment.
The "colorbar-for-value-formatting" discussion is at #12473 (I personally just patch matplotlib locally with that PR...). I think it's orthogonal to the feature here?
jklymak
approved these changes
May 26, 2021
The motivation is actually to provide get_cursor_data for hist2d, which uses a QuadMesh to draw itself (see the test). As it turns out, Collection.contains already contains the relevant code to find which path contains the mouse event, so just reuse that.
timhoffm
approved these changes
May 27, 2021
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is actually to provide get_cursor_data for hist2d, which
uses a QuadMesh to draw itself (see the test).
As it turns out, Collection.contains already contains the relevant code
to find which path contains the mouse event, so just reuse that.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).