Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix valinit argument to RangeSlider #19995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

dstansby
Copy link
Member

Fixes #19960. Added a test, and did some minor readability updates to surrounding code.

@dstansby dstansby added this to the v3.4.2 milestone Apr 16, 2021
Copy link
Contributor

@ianhi ianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks for fixing my mistake!

I kind of wish that we could raise an error if valinit didn't fit inside the min and max values instead of silently changing the valinit. But that would inconsistent with the Slider.

@QuLogic QuLogic merged commit 1ba3ff1 into matplotlib:master Apr 16, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 16, 2021
QuLogic added a commit that referenced this pull request Apr 17, 2021
…995-on-v3.4.x

Backport PR #19995 on branch v3.4.x (Fix valinit argument to RangeSlider)
@dstansby dstansby deleted the valinit-fix branch April 17, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to init RangeSlider with valinit attribute
4 participants