Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove ax fixture from category tests. #20000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 16, 2021

PR Summary

It saves only a line in each test, which is not worth the indirection.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@timhoffm
Copy link
Member

Anybody can merge after CI pass.

It saves only a line in each test, which is not worth the indirection.
@dstansby dstansby merged commit c7ebf91 into matplotlib:master Apr 17, 2021
@QuLogic QuLogic deleted the no-ax-fixture branch April 19, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants