Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Expire deprecation of AxesDivider defaulting to zero pads. #20064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

Expire deprecation of AxesDivider defaulting to zero pads. #20064

merged 1 commit into from
Apr 28, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 24, 2021

Note that the semantics of the rcParams are relative sizes, so they
should be interpreted as such here too.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added this to the v3.5.0 milestone Apr 24, 2021
@anntzer
Expire deprecation of AxesDivider defaulting to zero pads.
352821e 
Note that the semantics of the rcParams are *relative* sizes, so they
should be interpreted as such here too.
@QuLogic
Copy link
Member

QuLogic commented Apr 27, 2021 •
edited
Loading

Is self._xref fixed, or does it change as Axes are added? IOW, should it default to f'{rcParams[...space] * 100}%'?

@anntzer
Copy link
Contributor Author

anntzer commented Apr 27, 2021

From a quick check: xref never changes (it should basically be understood as the "central" axes, I guess). Even if it did, the pad is currently (before this pr) constructed as Size.from_any(pad, self._xref) so it would keep using a reference to the current xref.

@QuLogic
Copy link
Member

QuLogic commented Apr 28, 2021

Well, xref is a dynamic thing with a get_size, but I see it inherits from something with __rmul__ that ends up as a Fraction anyway, the same as if pad were a percentage string.

@QuLogic QuLogic merged commit 679ca17 into matplotlib:master Apr 28, 2021
@anntzer anntzer deleted the adp branch April 28, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: consistency Maintenance topic: mpl_toolkit
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm