-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
fix some http: -> https: URLs #20088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Apr 27, 2021
QuLogic
requested changes
Apr 27, 2021
Thanks for the comments. I've now used deadlink and went for a more conservative change.
|
timhoffm
reviewed
Jun 23, 2021
Co-authored-by: Tim Hoffmann <[email protected]>
QuLogic
reviewed
Jul 9, 2021
Co-authored-by: Elliott Sales de Andrade <[email protected]>
There's just the one typo left above. |
Even that was outdated. |
No, it's missing the closing parenthesis (which may need to be separated from the URL, now that I think about it.) |
Right, fixed now. |
QuLogic
approved these changes
Jul 16, 2021
Probably should be squash merged. |
timhoffm
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I scanned the code for outdated http: URLs and converted them to https: (where possible). Also following some permanent redirects.