-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add tricontour/tricontourf arguments(corner_mask, vmin vmax, antialiased, nchunk, hatches) documentation #20135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
on to the backend and also requires slightly less RAM. It can | ||
however introduce rendering artifacts at chunk boundaries depending | ||
on the backend, the *antialiased* flag and value of *alpha*.""") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should only be two empty lines between functions.
This causes flake8 to complain: "E303 too many blank lines (3)".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, but you should make the change @timhoffm suggested...
Removed the empty line. |
Thanks @AkM-2018 ! |
…rner_mask, vmin vmax, antialiased, nchunk, hatches) documentation
…135-on-v3.4.x Backport PR #20135 on branch v3.4.x (Add tricontour/tricontourf arguments(corner_mask, vmin vmax, antialiased, nchunk, hatches) documentation)
This has been prematurely merged. There are no |
I'll correct that |
@AkM-2018 Thanks. It will have to be another PR now that this has been merged. |
@ianthomas23 Please review the pull request #20171 |
PR Summary
Related to #19431
Some contour/contourf arguments which also work with tricontour/tricontourf are documented.
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).