Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add tricontour/tricontourf arguments(corner_mask, vmin vmax, antialiased, nchunk, hatches) documentation #20135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2021

Conversation

AkM-2018
Copy link
Contributor

@AkM-2018 AkM-2018 commented May 2, 2021

PR Summary

Related to #19431

Some contour/contourf arguments which also work with tricontour/tricontourf are documented.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@timhoffm timhoffm added this to the v3.4.2 milestone May 2, 2021
on to the backend and also requires slightly less RAM. It can
however introduce rendering artifacts at chunk boundaries depending
on the backend, the *antialiased* flag and value of *alpha*.""")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

There should only be two empty lines between functions.

This causes flake8 to complain: "E303 too many blank lines (3)".

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, but you should make the change @timhoffm suggested...

@AkM-2018
Copy link
Contributor Author

AkM-2018 commented May 3, 2021

Removed the empty line.
Is there anything else that needs to be changed/added?

@jklymak jklymak merged commit 842f1e6 into matplotlib:master May 3, 2021
@jklymak
Copy link
Member

jklymak commented May 3, 2021

Thanks @AkM-2018 !

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 3, 2021
…rner_mask, vmin vmax, antialiased, nchunk, hatches) documentation
QuLogic added a commit that referenced this pull request May 3, 2021
…135-on-v3.4.x

Backport PR #20135 on branch v3.4.x (Add tricontour/tricontourf arguments(corner_mask, vmin vmax, antialiased, nchunk, hatches) documentation)
@ianthomas23
Copy link
Member

This has been prematurely merged. There are no corner_mask or nchunk arguments to tricontour(f).

@AkM-2018
Copy link
Contributor Author

AkM-2018 commented May 6, 2021

I'll correct that

@ianthomas23
Copy link
Member

@AkM-2018 Thanks. It will have to be another PR now that this has been merged.

@AkM-2018
Copy link
Contributor Author

AkM-2018 commented May 6, 2021

@ianthomas23 Please review the pull request #20171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants