Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Speedup Line2D marker color setting. #20197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 10, 2021

np.any is quite slow, so avoid it if no numpy arrays are involved.

Because all ticks internally use lines, this change already speeds up

MPLBACKEND=agg python -mtimeit -s 'from matplotlib.figure import Figure' -- 'Figure().subplots(10, 10)'

by ~5%.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

np.any is quite slow, so avoid it if no numpy arrays are involved.

Because all ticks internally use lines, this change already speeds up
```
MPLBACKEND=agg python -mtimeit -s 'from matplotlib.figure import Figure' -- 'Figure().subplots(10, 10)'
```
by ~5%.
@tacaswell tacaswell added this to the v3.5.0 milestone May 10, 2021
@jklymak jklymak merged commit 4013e50 into matplotlib:master May 11, 2021
@anntzer anntzer deleted the fastlinemarkercolor branch May 11, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants