Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup axisartist in preparation for future changes. #20206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 11, 2021

axisartist stores in .grid_info various intermediary calculations used
to draw gridlines (which may be curved) and ticks. It may be helpful to
change the internal representation of this info in the future (e.g.
using Paths directly rather than x, y arrays which have to be
continuously packed and unpacked), but doing so means that the attribute
should become private first.

Also remove the private _get_line_path, which was added in 008b765 but
apparently never ever used (we can always reintroduce something like
that if needed).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

axisartist stores in .grid_info various intermediary calculations used
to draw gridlines (which may be curved) and ticks.  It may be helpful to
change the internal representation of this info in the future (e.g.
using Paths directly rather than x, y arrays which have to be
continuously packed and unpacked), but doing so means that the attribute
should become private first.

Also remove the private _get_line_path, which was added in 008b765 but
apparently never ever used (we can always reintroduce something like
that if needed).
@timhoffm timhoffm merged commit b6a6414 into matplotlib:master May 12, 2021
@anntzer anntzer deleted the aagi branch May 12, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants